Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logs for autosubmit triage #1987

Merged
merged 1 commit into from
Jul 18, 2022
Merged

Add logs for autosubmit triage #1987

merged 1 commit into from
Jul 18, 2022

Conversation

keyonghan
Copy link
Contributor

@keyonghan keyonghan mentioned this pull request Jul 18, 2022
Closed
@ricardoamador
Copy link
Contributor

Make sure that if any of the objects you are using in the logging are from the github package we import they support the toString method for interpolation. Otherwise looks good. I like that we are adding more logging.

ricardoamador
ricardoamador approved these changes Jul 18, 2022
View reviewed changes
Copy link
Contributor

@ricardoamador ricardoamador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keyonghan
Copy link
Contributor Author

Make sure that if any of the objects you are using in the logging are from the github package we import they support the toString method for interpolation. Otherwise looks good. I like that we are adding more logging.

Thanks. We used pullRequest here, which has the toString set up.

@keyonghan keyonghan added the autosubmit Merge PR when tree becomes green via auto submit App. label Jul 18, 2022
@auto-submit auto-submit bot merged commit b6282f2 into flutter:main Jul 18, 2022
@keyonghan keyonghan mentioned this pull request Jul 18, 2022
Merged
@keyonghan
Copy link
Contributor Author

Make sure that if any of the objects you are using in the logging are from the github package we import they support the toString method for interpolation. Otherwise looks good. I like that we are adding more logging.

Thanks. We used pullRequest here, which has the toString set up.

Oops, there is only a toJson function. I am updating the log here: #1988. Sorry for that.

@keyonghan keyonghan deleted the autosubmit_triage branch March 13, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricardoamador ricardoamador ricardoamador approved these changes

@yusuf-goog yusuf-goog Awaiting requested review from yusuf-goog

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keyonghan @ricardoamador