-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to null safety #47
base: master
Are you sure you want to change the base?
Conversation
Please merge this PR |
Can you take a look guys, @2534290808 , @udiedrichsen @Slackboi please? |
Merge Please 🙏 |
@jibiel Thanks for the PR dependency_overrides:
# Required for null-safety
# PR: https://github.com/flutter-studio/flutter-icons/pull/47
flutter_icons:
git:
url: git://github.com/jibiel/flutter-icons.git
ref: master |
When will this be merged in? Waiting for this to migrate my app to null safety |
Super looking to get this merged |
Pull request has been here for a month now. When can we expect this to be merged? |
One pull request has been sitting on this repo for almost 2 years... |
flutter pub get |
@jibiel would you be willing to take over maintenance on this repo with your fork? Renamed to flutter-vector-icons and added to pub.dev under that name of course. |
Not sure I'm very motivated and interested to do so. Since the PR was opened I've switched to a more modular vendor packages — Don't know how this all will compile in the final build yet, but the package takes 16MB unpacked and knowing that you include dozen of fonts and thousands of icons in the app and using only 1-5% of them is kinda strange. You are free to use the code from my fork however you see fit, though. |
Cheers |
I pushed out a fork which includes all missing icons including Fontisto fonts and jibiel's fixes for null safety support: https://pub.dev/packages/flutter_font_icons |
Thanks, I thought of doing so. We'll keep using flutter_font_icons and do make someone like me as contributer, so that we can keep that alive |
9cf4b48 fixes the majority of the analyzer warnings (mostly redundant
const
declarations).0889610 migrates the package to null safety.
Notes:
author
pubspec.yml
attribute is no longer supported.Please consider this PR for release, because the package complicates migration to null safety for the apps that using it.
Fixes #41.
Fixes #45.
Fixes #46.