Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rake task for building SBOM files #4356

Closed
wants to merge 2 commits into from
Closed

Add Rake task for building SBOM files #4356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4465343
Add task for building SBOM files
cosmo0920 Dec 4, 2023
8cb884f
Add generated SBOM files
cosmo0920 Dec 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions Rakefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,4 +76,12 @@ task :coverity do
FileUtils.rm_rf(['./cov-int', 'cov-fluentd.tar.gz'])
end

desc 'Build SBOM files'
task :sbom do
require 'fluent/version'
version = ENV["SBOM_VERSION"] || Fluent::VERSION
sh "docker sbom fluent/fluentd:v#{version}-debian-amd64-1.0 --output licenses/fluentd-latest.spdx.json --format spdx-json"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it use specific version of sbom plugin?
https://github.com/docker/sbom-cli-plugin

I've locally executed, it seems outcome is bit different.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just using with sbom subcommand which is included in Docker Desktop 4.24.2 (124339).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the generated SBOM files are not comfortable for y'all, I'll remove the commit 8cb884f from this PR. What do you think?

Copy link
Contributor

@kenhys kenhys Dec 15, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cosmo0920

Basically, it is good thing to provide SBOM, but I'm not sure it should be managed in fluent/fluentd.

By the way, how about using result of tags?

`curl --silent https://hub.docker.com/v2/namespaces/fluent/repositories/fluentd/tags  | jq --raw-output '.results[] | select (.name | startswith("#{version}-debian-amd64-1.")) | .name'`
v1.16.3-debian-amd64-1.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, it's really good. And I agree to put SBOMs in fluent/fluent-docker-image instead of here.
Or, like as pixie, we need to implement SBOM like auto generated files in the future.
https://github.com/pixie-io/pixie/tree/main/tools/licenses

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fluent/fluentd-docker-image#370

sh "docker sbom fluent/fluentd:v#{version}-debian-amd64-1.0 --output licenses/fluentd-latest.cyclonedx.json --format cyclonedx-json"
end

task default: [:test, :build]
Loading
Loading