This patch supports sending logs over UDP #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To use UDP you need to specify parameter ``host`` of FluentHandler as udp://<ip>[:<port>].
|
Looks like this PR addresses #75. |
2 similar comments
|
JSON support should be separated to other PR. |
repeatedly
reviewed
Apr 5, 2017
| def close(self): | ||
| super(TCPServer, self).close() | ||
| if self.accepted_connection: | ||
| self.accepted_connection.close() |
There was a problem hiding this comment.
should set None to accepted_connection?
| # that all encoding is utf-8. | ||
| return list(Unpacker(self._buf, encoding='utf-8')) | ||
|
|
||
| return list(messages) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To send logs over udp you need to specify host parameter as udp://ip[:port]. If you want to use TCP you may specify no prefixes, e.g, localhost or define host as tcp://ip[:port].
Also I have made some changes in tests, namely, I have replaced thread-based realization of fluent's mock with thin wrapper of socket object. It makes possible to use old tests to test both tpc and udp implementations. Also it makes tests more straight and clear, because you can check messages recieved by mock in real-time (now you cannot check messages before connection to mock is closed).