#135 Error handling and flushing message on reconnection. #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@okkez Please review the changes and let me know if there are anything more to be done. |
|
@sphansekar-cci Please check DCO result. |
Approx. 23x speedup Signed-off-by: Zach Bjornson <[email protected]>
Signed-off-by: Zach Bjornson <[email protected]>
Signed-off-by: Zach Bjornson <[email protected]>
Signed-off-by: Zach Bjornson <[email protected]>
This technique of exporting methods also thwarts some optimizations. It doesn't look like `sender` can ever be falsy? Signed-off-by: Zach Bjornson <[email protected]>
Signed-off-by: Zach Bjornson <[email protected]>
Signed-off-by: Zach Bjornson <[email protected]>
Signed-off-by: Zach Bjornson <[email protected]>
Signed-off-by: Zach Bjornson <[email protected]>
Type info is expensive to check Signed-off-by: Zach Bjornson <[email protected]>
Signed-off-by: Zach Bjornson <[email protected]>
Signed-off-by: Zach Bjornson <[email protected]>
Signed-off-by: Zach Bjornson <[email protected]>
Signed-off-by: Zach Bjornson <[email protected]>
* Line 213L: Unnecessary because `_doConnect()` invokes its callback asynchronously. Just need one `nextTick` on line 223R so that all paths invoke the cb async. * Line 222L: `_disconnect()` is sync, no need to wait for next tick to reconnect. * Line 338L: `_flushSendQueue()` is invoked only on line 114, which is an async callback. Signed-off-by: Zach Bjornson <[email protected]>
Because "ts" is ambiguous name. Signed-off-by: Kenji Okimoto <[email protected]>
Signed-off-by: Kenji Okimoto <[email protected]>
Signed-off-by: Kenji Okimoto <[email protected]>
Signed-off-by: Kenji Okimoto <[email protected]>
Signed-off-by: Kenji Okimoto <[email protected]>
sphansekar-cci
force-pushed
the
reconnect-and-flush-on-reconnect
branch
from
bf39619 to
999d4e4
Compare
Signed-off-by: Sanket Phansekar <[email protected]>
|
@okkez It's done. |
|
Thanks! |
|
When can I expect for the new version to be released? |
|
Maybe after #132 will be resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#135 Fixed.