in_opentelemetry: Propogate tag in http2 metrics and trace handlers #9635
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason whoever first wrote the
in_opentelemetry
plugin's HTTP/2 codepaths wrote it in a way that no/null tags were what always got passed into the Fluentbit routing engine. This PR fixes up what should be the last remaining cases not passing the tag through - the metrics and trace cases of the HTTP/2 codepath specifically. Should fully fix #8734 (i.e. fix it for the (default!) HTTP/2 mode and not force users to use the HTTP/1 codepath to get this behaviour).Testing
Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.