Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in_opentelemetry: Propogate tag in http2 metrics and trace handlers #9635

Merged

Conversation

nuclearpidgeon
Copy link
Contributor

@nuclearpidgeon nuclearpidgeon commented Nov 23, 2024

For some reason whoever first wrote the in_opentelemetry plugin's HTTP/2 codepaths wrote it in a way that no/null tags were what always got passed into the Fluentbit routing engine. This PR fixes up what should be the last remaining cases not passing the tag through - the metrics and trace cases of the HTTP/2 codepath specifically. Should fully fix #8734 (i.e. fix it for the (default!) HTTP/2 mode and not force users to use the HTTP/1 codepath to get this behaviour).

Testing

  • Example configuration file for the change attached
service:
    log_level: debug
pipeline:
    inputs:
        - name: opentelemetry
          tag_from_uri: true
          http2: true
    outputs:
        - name: 'stdout'
          match: 'v1_metrics'
        - name: 'stdout'
          match: 'v1_traces'
  • Debug log output from testing the change attached
  • Attached Valgrind output that shows no leaks or memory corruption was found

Documentation

  • [N/A] Documentation required for this feature - No

Backporting

  • This fix probably should be backported to the latest stable release, but it should probably get merged to master first.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

@nuclearpidgeon
Copy link
Contributor Author

CC: @jpvallez

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tag_from_uri in opentelemetry input plugin has no effect
2 participants