feat(offers): marketplace v2 offer #131
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
* feat(Deals): add resource information * fix(Deals): remove effectors * fix(deals): update version ts-client * feat(deal): show rended resources * fix(subgraph): update SUBGRAPH_URL link * fix(DealsTable): add column's header for max renting period * fix(DealInfo): fix DealInfo * fix(deal-ts-clients): update deal-ts-clients * fix(DealInfo): remove dwiced component * fix(DealInfo): fix display details * fix(Deals): update UI for deals/dealinfo page * fix(DealInfo): fix table * feat(ts-client): bump version * fix(deals): refactor deals and add getResourceName * fix(ResourceTable): refactor * fix(getResourceName): Update src/utils/getResourceName.ts Co-authored-by: shamsartem <[email protected]> * fix(WorkersTable): refactor --------- Co-authored-by: shamsartem <[email protected]>
src/components/ErrorBoundary.tsx
Outdated
There was a problem hiding this comment.
I would suggest to just do try catch in the code instead of using this
I personally never used it, I always thought this is useful basically only for third party components that might fail and it's best to write the code in such a way that it doesn't fail like that
There was a problem hiding this comment.
I added check for that and remove ErrorBoundary here #135
| quantity: string | ||
| metadata?: string |
There was a problem hiding this comment.
I am curious why metadata is optional. All resources have metadata right?
There was a problem hiding this comment.
We have some problems with resolving ResourceDescription data in ResourceData but fixed that in the Indexer. I will update ts-client little bit later
| resources: { | ||
| id: string | ||
| type: number | ||
| quantity: string | ||
| metadata?: string | ||
| }[] | ||
| workers?: | ||
| | { | ||
| id: string | ||
| peer: { | ||
| id: string | ||
| resources?: | ||
| | { | ||
| id: string | ||
| details: string | ||
| resource?: { | ||
| metadata: string | ||
| type: number | ||
| id: string | ||
| } | ||
| }[] | ||
| | null | ||
| } | ||
| }[] | ||
| | null |
There was a problem hiding this comment.
is this comming from indexer? should be possible to use generated types instead of this huge type definition here and in other places as well
There was a problem hiding this comment.
Yes, it's better to use types from ts-deal-client. We have some improvements in the Indexer. I wanna check them and add the regarding changes into ts-client and remove special types like that here
* feat(DataCenters): add DataCenterTable * feat(Menu): add DataCenter into Routing * feat(DataCentersTable): add datacenters * fix(DataCenters): fix types * feat(OfferResourceTable): better price formatting * feat(resources): add Resources page (#136) feat(resources): add resources page and update datacenters * feat(ts-client): update ts-client * fix(DataCentersTable): fix paggination * feat(datacenter): show datacenter info * feat(datacenters): show providers/peers * fix(DataCenter): remove unfinished Datacenter page * feat(ts-client): update deal-ts-client * fix(JsonToYamlView): remove ErrorBoundary
No description provided.