-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/voice allocator #158
Open
tremblap
wants to merge
19
commits into
flucoma:main
Choose a base branch
from
tremblap:feature/voice-allocator
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
my hunch is that around line 184 of the wrapper we need to do something - most probably a modulo around the size of one input which we would query/pass I don't know how |
… sure how I get that shape of output when it should be 3 of in.asArray.size
# Conflicts: # .github/workflows/release.yml
# Conflicts: # include/FluidSCWrapper.hpp # include/wrapper/RealTimeBase.hpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
an almost working attempt at it. Not changing the wrapper is most probably the culprit but kr inputs have to arrive together bundled so the rationale here would be to keep it as a single kr in of format in+in1+in2
it is almost working - monitoring the state of the data, before it crashes to overwrite in triple input size, this gets the right values in:
```{FluidVoiceAllocator.kr(DC.kr((0..4)), DC.kr((10..14)), DC.kr((100..104))).poll(1);Silent.ar}.play````
any input welcome