Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix replay #346

Closed
wants to merge 1 commit into from
Closed

Fix replay #346

wants to merge 1 commit into from

Conversation

quthla
Copy link
Contributor

@quthla quthla commented Jul 21, 2024

No description provided.

@flubshi
Copy link
Owner

flubshi commented Jul 22, 2024

Thanks for your PR. Since I don't know if the changed parameters for the HTTP request have any side-effects, I just took the actual fix from line 1524.
Could you please explain why you changed/added requestMuxInstrumentation and processOutcomeField?

@quthla
Copy link
Contributor Author

quthla commented Jul 22, 2024

It's what the web app does and I thought it makes sense to replicate its behavior as long as it doesn't break anything. There were no issues.

@flubshi flubshi closed this Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants