Update MariaDB from 10.11 to 11.4 (LTS) #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdambekalns
commented
Sep 24, 2024
| container_name: local_beach_database | ||
| networks: | ||
| - local_beach | ||
| volumes: | ||
| - {{databasePath}}:/var/lib/mysql | ||
| healthcheck: | ||
| test: "/usr/bin/mysql --user=root --password=password --execute \"SHOW DATABASES;\"" | ||
| test: "/usr/bin/mariadb --user=root --password=password --execute \"SHOW DATABASES;\"" |
There was a problem hiding this comment.
As of MariaDB 11.0 the image no longer contains mysql-named binaries.
| @@ -71,7 +71,7 @@ func handleStartRun(cmd *cobra.Command, args []string) { | |||
| } | |||
|
|
|||
| log.Debug("Creating project database (if needed) ...") | |||
| commandArgs = []string{"exec", "local_beach_database", "/bin/bash", "-c", "echo 'CREATE DATABASE IF NOT EXISTS `" + sandbox.ProjectName + "`' | mysql -u root --password=password"} | |||
| commandArgs = []string{"exec", "local_beach_database", "/bin/bash", "-c", "echo 'CREATE DATABASE IF NOT EXISTS `" + sandbox.ProjectName + "`' | mariadb -u root --password=password"} | |||
There was a problem hiding this comment.
As of MariaDB 11.0 the image no longer contains mysql-named binaries.
| @@ -177,6 +177,12 @@ func startLocalBeach() error { | |||
| return errors.New("failed to check for database server container health") | |||
| } | |||
| if strings.TrimSpace(output) == "healthy" { | |||
| commandArgs := []string{"exec", "local_beach_database", "mariadb-upgrade", "-u", "root", "--password=password"} | |||
There was a problem hiding this comment.
This runs the upgrade – on every start. But since it does no harm to run it when not needed, I chose this way.
An alternative would be to check if the upgrade is needed (using mariadb-upgrade --check-if-upgrade-is-needed), but that seemed superfluous.
robertlemke
approved these changes
Oct 14, 2024
This upgrades the used MariaDB from version 10.11 to the current long-term series, MariaDB 11.4, maintained until May 2029.
kdambekalns
force-pushed
the
task/upgrade-mariadb
branch
from
d09508c to
7aebe68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades the used MariaDB from version 10.11 to the current long-term series, MariaDB 11.4, maintained until May 2029.