Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleanup #63

Merged
merged 6 commits into from
Dec 11, 2024
Merged

Code cleanup #63

merged 6 commits into from
Dec 11, 2024

Conversation

kdambekalns
Copy link
Member

No description provided.

This package now requires at least PHP 8.1 and introduces support for PHP 8.4
@kdambekalns kdambekalns self-assigned this Dec 10, 2024
@kdambekalns
Copy link
Member Author

The failure on PHP 8.4 (with lowest dependencies) is due to deprecation issues in Guzzle and PhpUnit (oh the irony). Locally the tests finish (with warnings), instead of breaking. 🤷‍♂️

Copy link
Member

@robertlemke robertlemke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kdambekalns kdambekalns merged commit 54b2cbe into main Dec 11, 2024
8 checks passed
@kdambekalns kdambekalns deleted the task/cleanup branch December 11, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants