BUGFIX: Same bucket, different keyPrefixes, treat as "Two Buckets" mode

[baschny]

We have a setup like this:

Neos:
  Flow:
    resource:
      storages:
        s3PersistentResourcesStorage:
          storage: 'Flownative\Aws\S3\S3Storage'
          storageOptions:
            bucket: 'our-bucket'
            keyPrefix: 'storage/'
      targets:
        s3PersistentResourcesTarget:
          subdivideHashPathSegment: true
          target: 'Flownative\Aws\S3\S3Target'
          targetOptions:
            bucket: 'our-bucket'
            keyPrefix: 'public/'
            baseUri: 'https://....cloudfront.net/public/'

This works great with Neos v7 and now we are upgrading to Neos v8, so we needed to upgrade this package from v2.4.2 to v2.6.2, which includes the "new feature" #49, which was later updated with this fix #63.

Now in our setup we are using just one bucket, but since the prefix is different, we want to make the publishing really "copy" the file over as it was before, so that we get a "pretti(er)" URL with the filename included. This is not working anymore: You end up with broken images in the backend, because its not copying the files at all.

This fix simply adds the check if also the prefix is also not the same, and then fallbacks to the "good old two buckets" mode as before.

[baschny]

@kdambekalns what do you think?

[kdambekalns]

To be honest copying the file when different prefixes are used sound a) totally reasonable, b) like the way to go and c) a good idea. 😉 Otherwise using different prefix simply isn't possible.

What do you think, @robertlemke?

[robertlemke]

Makes sense! If you tested this for real, let's merge and release it.

[baschny]

I just tested our use case, which was broken after this FEATURE was introduced. I have not tested the other possible setup variations, but I expect that this change at least does not break anything that was not yet broken anyway.