Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: UI refs pt1 #2727

Merged
merged 3 commits into from
Jan 31, 2024
Merged

feat: UI refs pt1 #2727

merged 3 commits into from
Jan 31, 2024

Conversation

markphelps
Copy link
Collaborator

Part of #2711

Adds ability to request different references from backend

Still to do (in followup PRs):

  • expose internal API to return available references from backend
  • expose UI branch picker dropdown in UI

@markphelps markphelps requested a review from a team as a code owner January 31, 2024 16:20
@markphelps markphelps requested review from erka and removed request for a team January 31, 2024 16:22
@markphelps markphelps requested a review from a team January 31, 2024 16:22
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dd179a9) 73.03% compared to head (dfa8baf) 73.03%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2727   +/-   ##
=======================================
  Coverage   73.03%   73.03%           
=======================================
  Files          85       85           
  Lines        8374     8374           
=======================================
  Hits         6116     6116           
  Misses       1880     1880           
  Partials      378      378           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@erka erka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@markphelps markphelps merged commit 36b27fe into main Jan 31, 2024
33 checks passed
@markphelps markphelps deleted the ui-branch-picker branch January 31, 2024 17:13
markphelps added a commit that referenced this pull request Feb 1, 2024
…nto onboarding-page

* 'onboarding-page' of https://github.com/flipt-io/flipt:
  docs(examples): added example how to run flipt behind nginx (#2726)
  chore(deps): bump github.com/moby/buildkit in /_tools (#2728)
  feat: UI refs pt1 (#2727)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants