feat(grpc): grpc keepalive configuration #2621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2621 +/- ##
==========================================
+ Coverage 71.38% 73.42% +2.04%
==========================================
Files 84 84
Lines 8013 8020 +7
==========================================
+ Hits 5720 5889 +169
+ Misses 1948 1766 -182
- Partials 345 365 +20 ☔ View full report in Codecov by Sentry. |
markphelps
reviewed
Jan 8, 2024
There was a problem hiding this comment.
Thanks @erka !! Some minor rename suggestions for consistency w other settings.
Co-authored-by: Mark Phelps <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe it's all that should be done in Flipt sources. All other is helm related
refs #2428