-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Package/windows #433
Conversation
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #433 +/- ##
==========================================
+ Coverage 87.35% 87.42% +0.07%
==========================================
Files 9 9
Lines 3740 3737 -3
==========================================
Hits 3267 3267
+ Misses 473 470 -3 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
…lient-sdks into package/windows * 'package/windows' of https://github.com/flipt-io/flipt-client-sdks: chore: bump browser sdk for release (#432)
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
It would be great to include the drop of node
FFI in PR description as it was replaced with wasm. The PR has a lot of changes and without context that drop could look strange in the future
Re: #141 (comment)
This pull request introduces several changes to the build and packaging workflows, as well as updates to support Windows in various SDKs. The most important changes include adding support for Windows builds, modifying the workflows to handle different platforms, and updating the SDKs to accommodate these changes.
Workflow Updates:
.github/workflows/package-ffi-engine.yml
.jobs:
in.github/workflows/package-ffi-engine.yml
..github/workflows/package-ffi-engine.yml
.SDK Updates:
flipt-client-dart/lib/src/flipt_evaluation_client.dart
.flipt-client-go/evaluation.go
.flipt-client-python/flipt_client/__init__.py
.flipt-client-ruby/lib/flipt_client.rb
.Codebase Simplification:
package/ffi/main.go
. [1] [2] [3]package/ffi/main.go
. [1] [2]These changes ensure that the build and packaging workflows are more robust and can handle multiple platforms, including Windows, while simplifying the codebase for better maintainability.