Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Package/windows #433

Merged
merged 12 commits into from
Oct 11, 2024
Merged

feat: Package/windows #433

merged 12 commits into from
Oct 11, 2024

Conversation

markphelps
Copy link
Contributor

@markphelps markphelps commented Oct 9, 2024

Re: #141 (comment)

This pull request introduces several changes to the build and packaging workflows, as well as updates to support Windows in various SDKs. The most important changes include adding support for Windows builds, modifying the workflows to handle different platforms, and updating the SDKs to accommodate these changes.

Workflow Updates:

  • Added support for triggering workflows on pull requests to the main branch in .github/workflows/package-ffi-engine.yml.
  • Replaced iOS and Android build targets with Windows in the matrix of jobs: in .github/workflows/package-ffi-engine.yml.
  • Added conditional logic for packaging and uploading artifacts based on the platform in .github/workflows/package-ffi-engine.yml.

SDK Updates:

  • Added Windows platform support in flipt-client-dart/lib/src/flipt_evaluation_client.dart.
  • Added Windows platform support in flipt-client-go/evaluation.go.
  • Added Windows platform support in flipt-client-python/flipt_client/__init__.py.
  • Updated library file paths to include Windows in flipt-client-ruby/lib/flipt_client.rb.
  • Removed unused Node FFI packaging as its now using WASM

Codebase Simplification:

  • Simplified the build process by removing unnecessary node build steps and focusing on essential includes in package/ffi/main.go. [1] [2] [3]
  • Consolidated package management and downloading logic, including adding a function to get the latest engine tag in package/ffi/main.go. [1] [2]

These changes ensure that the build and packaging workflows are more robust and can handle multiple platforms, including Windows, while simplifying the codebase for better maintainability.

@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.42%. Comparing base (1377365) to head (e6d7ebb).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #433      +/-   ##
==========================================
+ Coverage   87.35%   87.42%   +0.07%     
==========================================
  Files           9        9              
  Lines        3740     3737       -3     
==========================================
  Hits         3267     3267              
+ Misses        473      470       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@markphelps markphelps marked this pull request as ready for review October 10, 2024 17:46
@markphelps markphelps requested a review from a team as a code owner October 10, 2024 17:46
@markphelps markphelps mentioned this pull request Oct 10, 2024
6 tasks
Copy link
Collaborator

@erka erka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
It would be great to include the drop of node FFI in PR description as it was replaced with wasm. The PR has a lot of changes and without context that drop could look strange in the future

@kodiakhq kodiakhq bot merged commit b6ad842 into main Oct 11, 2024
18 checks passed
@kodiakhq kodiakhq bot deleted the package/windows branch October 11, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants