Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(java): fix package java client for musl #423

Closed
wants to merge 1 commit into from
Closed

Conversation

erka
Copy link
Collaborator

@erka erka commented Oct 4, 2024

No description provided.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.35%. Comparing base (4466cf8) to head (5969c59).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #423   +/-   ##
=======================================
  Coverage   87.35%   87.35%           
=======================================
  Files           9        9           
  Lines        3740     3740           
=======================================
  Hits         3267     3267           
  Misses        473      473           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@erka
Copy link
Collaborator Author

erka commented Oct 4, 2024

@markphelps Currently we got glibc libfliptengine.so into the musl jar. I suspect we rename the folder in a wrong way. But I can't verify it local. Dagger is a nightmare in some way between versions.

@markphelps
Copy link
Contributor

@markphelps Currently we got glibc libfliptengine.so into the musl jar. I suspect we rename the folder in a wrong way. But I can't verify it local. Dagger is a nightmare in some way between versions.

@erka I think i might have fixed this in my latest push to the other PR: https://github.com/flipt-io/flipt-client-sdks/pull/422/files#diff-2d2d49a7b0d105b3823a741b2e434752094d4ad843871f550d96f47d32cb4610R419

I'm trying to resolve the issue described here by also packaging in the Darwin libs as well in the musl SDKs

@erka erka closed this Oct 4, 2024
@erka erka deleted the java-musl branch October 4, 2024 15:33
@erka
Copy link
Collaborator Author

erka commented Oct 4, 2024

@markphelps Please let me know when you publish 0.0.2. I will try it locally too.

@markphelps
Copy link
Contributor

@markphelps Please let me know when you publish 0.0.2. I will try it locally too.

It should be on mvn central by now I would think. Released it about 45 minutes ago

@erka
Copy link
Collaborator Author

erka commented Oct 4, 2024

It should be on mvn central by now I would think. Released it about 45 minutes ago

@markphelps yep, it's available and it works in my test app in alpine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants