Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: wasm non-js #328

Closed
wants to merge 5 commits into from
Closed

feat: wasm non-js #328

wants to merge 5 commits into from

Conversation

markphelps
Copy link
Contributor

Re: #327

POC to try using plain wasm / wasmtime to do evaluation without FFI

will fill out more details later

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0.41322% with 241 lines in your changes missing coverage. Please review.

Project coverage is 84.09%. Comparing base (af8bca5) to head (37021de).

Files Patch % Lines
flipt-engine-wasm/src/lib.rs 0.00% 155 Missing ⚠️
flipt-engine-wasm-js/src/lib.rs 0.00% 77 Missing ⚠️
flipt-evaluation/src/models/common.rs 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #328      +/-   ##
==========================================
- Coverage   88.38%   84.09%   -4.29%     
==========================================
  Files          10       11       +1     
  Lines        3686     3874     +188     
==========================================
  Hits         3258     3258              
- Misses        428      616     +188     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GeorgeMac
Copy link
Member

Very excited to see us explore WASM more for this.
Just a note though (you're probably aware): wasmtime-go is CGO and C FFI. So doesn't address the problem of having to have wasmtime installed for the host OS in order to use these clients. As opposed to say wazero which can be entirely statically compiled into the client.

@markphelps
Copy link
Contributor Author

Very excited to see us explore WASM more for this. Just a note though (you're probably aware): wasmtime-go is CGO and C FFI. So doesn't address the problem of having to have wasmtime installed for the host OS in order to use these clients. As opposed to say wazero which can be entirely statically compiled into the client.

yeah we could try wazero as well instead of wasmtime. another potential option is use an approach like mentioned here #141 (comment), re libkafka maybe? would the end user still need to install wasmtime locally then?

@markphelps markphelps closed this Aug 22, 2024
@markphelps markphelps deleted the wasm branch October 24, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants