Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Error types #30

Merged
merged 5 commits into from
Dec 12, 2023
Merged

feat: Error types #30

merged 5 commits into from
Dec 12, 2023

Conversation

markphelps
Copy link
Contributor

fixes: FLI-740

  • uses custom error types which are more appropriate for a library
  • adds attribution
  • some more readme updates

@linear Linear
Copy link

linear bot commented Dec 12, 2023

FLI-740 Use proper error types in Rust

We should return proper error types to the end users as this is a library

@markphelps markphelps requested a review from GeorgeMac December 12, 2023 15:44
@markphelps markphelps enabled auto-merge (squash) December 12, 2023 15:55
@markphelps markphelps merged commit 1cbd333 into main Dec 12, 2023
5 checks passed
@markphelps markphelps deleted the error-types branch December 12, 2023 16:14
This was referenced Dec 24, 2023
Closed
Merged
Merged
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeorgeMac GeorgeMac GeorgeMac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markphelps @GeorgeMac