chore: automate client installs; update readmes #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markphelps
commented
Dec 6, 2023
markphelps
commented
Dec 7, 2023
| "files": [ | ||
| "dist", | ||
| "ext" | ||
| ], |
There was a problem hiding this comment.
this packages the shared lib in the node module instead of us relying on the env var and for it to exist elsewhere on the host
markphelps
changed the title
yquansah
reviewed
Dec 7, 2023
flipt-client-node/src/index.ts
Outdated
| let libfile = ''; | ||
|
|
||
| // get absolute path to libfliptengine | ||
| const path = require('path'); |
There was a problem hiding this comment.
Is there a way we can 'import' this on the top of the file?
yquansah
reviewed
Dec 7, 2023
| rm -rf flipt-client-node/*.tgz | ||
| rm -rf flipt-client-node/dist | ||
| rm -rf flipt-client-python/ext/$(LIB).* | ||
| rm -rf flipt-client-python/dist |
There was a problem hiding this comment.
Does python have a "dist" folder after a build?
There was a problem hiding this comment.
with poetry, yah it seemed to:
» ls flipt-client-python/dist/
flipt_client-0.0.1-py3-none-any.whl flipt_client-0.0.1.tar.gz
* main: feat: do not fail on non-existent namespace in Rust core (#26) chore: address comments chore: remove unnecessary code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flipt_clientinstead offlipt_client_python)TODO