Skip to content

Commit

Permalink
Merge branch 'main' into kotlin-client-sdk
Browse files Browse the repository at this point in the history
  • Loading branch information
markphelps authored Dec 7, 2024
2 parents 8a2aedd + 99d8a0d commit e42a011
Show file tree
Hide file tree
Showing 38 changed files with 1,501 additions and 1,313 deletions.
13 changes: 9 additions & 4 deletions .github/workflows/package-ffi-engine.yml
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,15 @@ jobs:
target: aarch64-apple-ios-sim
use_cross: false

# - name: Android-arm64
# os: ubuntu-latest
# target: aarch64-linux-android
# use_cross: true
- name: Android-arm64
os: ubuntu-latest
target: aarch64-linux-android
use_cross: true

- name: Android-x86_64
os: ubuntu-latest
target: x86_64-linux-android
use_cross: true

runs-on: ${{ matrix.platform.os }}

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-engines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ jobs:
run: cargo llvm-cov --all-features --workspace --lcov --output-path lcov.info

- name: Upload coverage to Codecov
uses: codecov/codecov-action@v4
uses: codecov/codecov-action@v5
with:
token: ${{ secrets.CODECOV_TOKEN }}
files: lcov.info
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-swift-sdk.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
override: true

- name: Install Swift
uses: swift-actions/setup-swift@v1
uses: swift-actions/setup-swift@v2
with:
swift-version: "5.9"

Expand Down
2 changes: 1 addition & 1 deletion .release-please-manifest.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"flipt-engine-ffi": "0.2.1",
"flipt-engine-ffi": "0.2.2",
"flipt-engine-wasm": "0.1.2"
}
8 changes: 4 additions & 4 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
Let us know how we can help!

- Use a **clear and descriptive title** for the issue to identify the problem.
- Describe the **exact steps** which reproduce the problem in as many details as possible.
- Describe the **exact steps** to reproduce the problem in as many details as possible.
- Include the language client you are using and the version.
- Include any **stack traces** with your error
- List versions you are using: Flipt, OS, etc.
Expand Down Expand Up @@ -64,11 +64,11 @@ The client shape should be as follows:

The client should interface with the engine to evaluate flags. The engine is responsible for connecting to the Flipt server, fetching flag state, and evaluating flags.

You don't have to build the engine from scratch in order to develop a new client. You can download the latest engine version from the [releases page](https://github.com/flipt-io/flipt-client-sdks/latest) for your platform and use it while developing the client.
You don't have to build the engine from scratch in order to develop a new client. You can download the latest engine version from the [releases page](https://github.com/flipt-io/flipt-client-sdks/releases/latest) for your platform and use it while developing the client.

### 4. Setup Tests (optional)

If you like to add tests using Dagger, you can follow the steps below. If you are not familiar with Dagger, you can skip this step and simply provide instructions for running the tests locally.
If you'd like to add tests using Dagger, you can follow the steps below. If you are not familiar with Dagger, you can skip this step and simply provide instructions for running the tests locally.

Feel free to ask the team for help with this step.

Expand All @@ -86,7 +86,7 @@ Add a new section to the [dependabot.yml](./.github/dependabot.yml) file for the

### 7. Create a PR

Create a PR with the changes and we will review it as soon as possible. Please add any language specific idioms when it comes to packaging the client. This will allow us to automate and publish the client to the appropriate package manager.
Create a PR with the changes and we will review it as soon as possible. Please add any language-specific idioms when it comes to packaging the client. This will allow us to automate and publish the client to the appropriate package manager.

### Conventional Commits

Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ Currently, we support the following languages/platforms:
| [React Web (Browser)](./flipt-client-react) | WASM | N/A | N/A |
| [Flutter/Dart](./flipt-client-dart) | FFI |||
| [C#](./flipt-client-csharp) | FFI |||
| [Swift](./flipt-client-swift) | FFI | N/A | N/A |

Documentation for each client can be found in the README of that client's directory.

Expand All @@ -78,7 +79,6 @@ Languages we are planning to support:
Languages we would like to support but lack expertise in:

1. [Kotlin](https://github.com/flipt-io/flipt-client-sdks/issues/264)
1. [Swift](https://github.com/flipt-io/flipt-client-sdks/issues/263)
1. [React Native](https://github.com/flipt-io/flipt-client-sdks/issues/345)

Want to see a client in a language we don't support? [Open an issue](https://github.com/flipt-io/flipt-client-sdks/issues/new?assignees=&labels=new-language&projects=&template=new_language.yml) and let us know!
Expand Down
Loading

0 comments on commit e42a011

Please sign in to comment.