Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add seperate variant attachment section with limit #288

Merged
merged 1 commit into from
Nov 6, 2024
Merged

chore: add seperate variant attachment section with limit #288

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions concepts.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,18 @@
that determines which main colors your users see when they login to your
application, then possible variants could include `dark`, `light` or `auto`.

<Tip>
Variants can also have JSON attachments. This allows you to store additional
data about a variant that can be used in your application at runtime.
</Tip>
#### Variant Attachments

Variants can also have JSON attachments. This allows you to store additional
data about a variant that can be used in your application at runtime.

<Warning>

Variant attachments are not used for evaluation, they are only used for runtime configuration.

Check warning on line 64 in concepts.mdx

View workflow job for this annotation

GitHub Actions / Vale 

[vale] reported by reviewdog 🐶
[Microsoft.Contractions] Use 'aren't' instead of 'are not'.

Raw Output:
{"message": "[Microsoft.Contractions] Use 'aren't' instead of 'are not'.", "location": {"path": "concepts.mdx", "range": {"start": {"line": 64, "column": 21}}}, "severity": "WARNING"}

Check warning on line 64 in concepts.mdx

View workflow job for this annotation

GitHub Actions / Vale 

[vale] reported by reviewdog 🐶
[Microsoft.Contractions] Use 'they're' instead of 'they are'.

Raw Output:
{"message": "[Microsoft.Contractions] Use 'they're' instead of 'they are'.", "location": {"path": "concepts.mdx", "range": {"start": {"line": 64, "column": 50}}}, "severity": "WARNING"}

The attachment size is limited to **1MB**.

</Warning>

![Variant Flags Example](/images/concepts/flags_variants.png)

Expand Down
Loading