Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cache): added new username property for redis and update the cache #203

Merged
merged 1 commit into from
Apr 11, 2024
Merged

chore(cache): added new username property for redis and update the cache #203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions configuration/overview.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,6 +297,7 @@ export FLIPT_CORS_ALLOWED_ORIGINS="http://localhost:3000 http://localhost:3001"
| cache.redis.min_idle_conn | Minimum number of idle connections in the pool | 0 | v1.25.0 |
| cache.redis.conn_max_idle_time | Maximum amount of time a connection can be idle | 30m | v1.25.0 |
| cache.redis.net_timeout | Network timeout for Redis connections | 0 | v1.25.0 |
| cache.redis.username | Username to access the Redis database | | v1.41.0 |

### Audit Events

Expand Down
6 changes: 3 additions & 3 deletions configuration/storage.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,7 +498,7 @@
<Note>
Certain OCI registries may require setting the OCI manifest version to something other than the default (`1.1`) to work correctly.

In this case, you can set the `FLIPT_STORAGE_OCI_MANIFEST_VERSION` environment variable or `storage.oci.manifest_version` configuration property to the desired version (e.g. `1.0`).
In this case, you can set the `FLIPT_STORAGE_OCI_MANIFEST_VERSION` environment variable or `storage.oci.manifest_version` configuration property to the desired version (e.g. `1.0`).

Check warning on line 501 in configuration/storage.mdx

View workflow job for this annotation

GitHub Actions / Vale 

[vale] reported by reviewdog 🐶
[Microsoft.Foreign] Use 'for example' instead of 'e.g.'.

Raw Output:
{"message": "[Microsoft.Foreign] Use 'for example' instead of 'e.g.'.", "location": {"path": "configuration/storage.mdx", "range": {"start": {"line": 501, "column": 172}}}, "severity": "WARNING"}

Check warning on line 501 in configuration/storage.mdx

View workflow job for this annotation

GitHub Actions / Vale 

[vale] reported by reviewdog 🐶
[Openly.Punctuation] Use 'eg' instead of 'e.g.'

Raw Output:
{"message": "[Openly.Punctuation] Use 'eg' instead of 'e.g.'", "location": {"path": "configuration/storage.mdx", "range": {"start": {"line": 501, "column": 172}}}, "severity": "WARNING"}

See [this issue](https://github.com/flipt-io/flipt/issues/2907) for more information.

Expand Down Expand Up @@ -618,7 +618,7 @@

Flipt supports both in-memory cache as well as [Redis](https://redis.io/) to enable faster reads and
evaluations. Enabling caching has been shown to speed up read performance by
several orders of magnitude.
several orders of magnitude if you are using a relational database.

<Warning>
Enabling in-memory caching when running more than one instance of Flipt isn't
Expand All @@ -631,7 +631,7 @@
- All flag reads and evaluation requests go through the cache
- Flag cache entries are purged whenever a write to a flag or its variants
occur or the TTL expires
- Evaluation cache entries are purged after the TTL expires only
- Cache entries are purged after the TTL expires only
- A cache miss will fetch the item from the database and add the item to the
cache for the next read
- A cache hit will simply return the item from the cache, not interacting with
Expand Down
Loading