Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli/validate): add documentation around --extra-schema #173

Merged
merged 6 commits into from
Jan 23, 2024

Conversation

GeorgeMac
Copy link
Member

Adds documentation around the new --extra-schema flag on flipt validate.
See: flipt-io/flipt#2677

@GeorgeMac GeorgeMac requested a review from a team as a code owner January 19, 2024 14:50
Copy link
Contributor

@markphelps markphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple minor suggestions

@@ -19,7 +19,7 @@ flipt validate [flags]
### Behavior

This command validates Flipt's declarative feature configuration files.
It looks for features flag definitions in the same way as Flipts declarative backends.
It looks for features flag definitions in the same way as Flipt's declarative backends.
Checkout the documentation on [locating flag state](/configuration/storage#locating-flag-state) to learn more about this process.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should introduce Cue here by puting something here about how it uses Cue under the hood, and link to the Cue project?

cli/commands/validate.mdx Outdated Show resolved Hide resolved
@markphelps markphelps added the pending release waiting on release of Flipt label Jan 19, 2024
@markphelps markphelps merged commit e649aa0 into main Jan 23, 2024
3 of 4 checks passed
@markphelps markphelps deleted the gm/flipt-validate-extra-schema branch January 23, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending release waiting on release of Flipt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants