Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add jwt docs #167

Merged
merged 7 commits into from
Jan 10, 2024
Merged

feat: add jwt docs #167

merged 7 commits into from
Jan 10, 2024

Conversation

markphelps
Copy link
Contributor

@markphelps markphelps requested a review from a team as a code owner January 9, 2024 18:58
yquansah
yquansah reviewed Jan 9, 2024
View reviewed changes
Copy link
Contributor

@yquansah yquansah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple of comments.

authentication/methods.mdx Outdated Show resolved Hide resolved
authentication/overview.mdx Outdated Show resolved Hide resolved
GeorgeMac
GeorgeMac requested changes Jan 10, 2024
View reviewed changes
Copy link
Member

@GeorgeMac GeorgeMac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs looks great. Couple addition suggestions and a couple corrections.

authentication/methods.mdx Outdated Show resolved Hide resolved
configuration/authentication.mdx Outdated Show resolved Hide resolved
configuration/authentication.mdx Outdated Show resolved Hide resolved
configuration/authentication.mdx Outdated Show resolved Hide resolved
@markphelps
Merge branch 'main' into jwt-docs
f2cf521
@markphelps
Merge branch 'main' into jwt-docs
cfc7b48 
* main:
  chore: add new grpc conn settings (#169)
  feat: add gcp docs (#168)
@markphelps
chore: address PR feedback
003680a
@markphelps
Merge branch 'jwt-docs' of https://github.com/flipt-io/docs into jwt-…
63846c4 
…docs

* 'jwt-docs' of https://github.com/flipt-io/docs:
  chore: Update authentication/methods.mdx
  chore: format code
@markphelps
Copy link
Contributor Author

Addressed feedback

GeorgeMac
GeorgeMac approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@GeorgeMac GeorgeMac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet

@markphelps markphelps merged commit cd69bd5 into main Jan 10, 2024
4 checks passed
@markphelps markphelps deleted the jwt-docs branch January 10, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeorgeMac GeorgeMac GeorgeMac approved these changes

@yquansah yquansah Awaiting requested review from yquansah

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@markphelps @GeorgeMac @yquansah