Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(commands): add bundle CLI documentation #142

Merged
merged 5 commits into from
Nov 15, 2023
Merged

feat(commands): add bundle CLI documentation #142

merged 5 commits into from
Nov 15, 2023

Conversation

GeorgeMac
Copy link
Member

Fixes FLI-680

Adds documentation around the new flipt bundle commands.
This applies to the currently unreleased Flipt v1.31.0.

@GeorgeMac GeorgeMac requested a review from a team as a code owner November 13, 2023 14:04
@markphelps markphelps added the pending release waiting on release of Flipt label Nov 13, 2023
markphelps
markphelps requested changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@markphelps markphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple minor wording changes

removing the flipt from all the command titles makes it look more uniform with what we already have, otherwise I think the titles can become rather repetitive:

CleanShot 2023-11-13 at 16 01 34

cli/commands/bundle/build.mdx Outdated Show resolved Hide resolved
cli/commands/bundle/list.mdx Outdated Show resolved Hide resolved
cli/commands/bundle/pull.mdx Outdated Show resolved Hide resolved
cli/commands/bundle/push.mdx Outdated Show resolved Hide resolved
cli/commands/bundle/build.mdx Outdated Show resolved Hide resolved
cli/commands/bundle/list.mdx Outdated Show resolved Hide resolved
@GeorgeMac GeorgeMac requested a review from markphelps November 14, 2023 16:39
@markphelps markphelps enabled auto-merge (squash) November 15, 2023 15:45
@markphelps markphelps merged commit bc7757c into main Nov 15, 2023
2 checks passed
@markphelps markphelps deleted the gm/bundle-cli-docs branch November 15, 2023 15:45
@markphelps markphelps removed the pending release waiting on release of Flipt label Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markphelps markphelps markphelps approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GeorgeMac @markphelps