Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update screenshots, import export docs #129

Merged
merged 2 commits into from
Oct 5, 2023
Merged

chore: update screenshots, import export docs #129

merged 2 commits into from
Oct 5, 2023

Conversation

markphelps
Copy link
Contributor

  • update all screenshots to latest versions
  • reword some import/export docs

@markphelps markphelps requested a review from a team as a code owner October 5, 2023 14:10
yquansah
yquansah approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@yquansah yquansah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

For users pre v1.28.0, will there be a way for them to know which options are available to them as far as import/export?

@markphelps
Copy link
Contributor Author

This looks good to me.

For users pre v1.28.0, will there be a way for them to know which options are available to them as far as import/export?

The help text for the commands should be enough IMO:

flipt import --help
flipt export --help

@markphelps markphelps merged commit 7b0c37b into main Oct 5, 2023
3 checks passed
@markphelps markphelps deleted the update-images-import-export branch October 5, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yquansah yquansah yquansah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markphelps @yquansah