update_RN_0.76.3 #1820
Draft
update_RN_0.76.3 #1820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems like building tvos now requires |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+60
to
+62
| `node ${doResolve(c.runtime.runtimeExtraProps?.reactNativePackageName || 'react-native')}/cli.js ${args.join( | ||
| ' ' | ||
| )} --config=${c.runtime.runtimeExtraProps?.reactNativeMetroConfigName || 'metro.config.js'}`, |
Check warning
Code scanning / CodeQL
Unsafe shell command constructed from library input Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI 18 days ago
To fix the problem, we should avoid constructing the shell command using string concatenation and instead use a safer method to pass arguments to the command. The child_process.execFile method is a safer alternative as it allows us to pass arguments as an array, avoiding shell interpretation.
- Replace the
executeAsynccall withchild_process.execFileto execute the command. - Construct the command and its arguments as separate elements in an array.
- Ensure all dynamic inputs are properly escaped or validated.
Suggested changeset
1
packages/sdk-react-native/src/iosRunner.ts
| @@ -58,7 +58,10 @@ | ||
| } | ||
| return executeAsync( | ||
| `node ${doResolve(c.runtime.runtimeExtraProps?.reactNativePackageName || 'react-native')}/cli.js ${args.join( | ||
| ' ' | ||
| )} --config=${c.runtime.runtimeExtraProps?.reactNativeMetroConfigName || 'metro.config.js'}`, | ||
| { | ||
| const command = 'node'; | ||
| const commandArgs = [ | ||
| `${doResolve(c.runtime.runtimeExtraProps?.reactNativePackageName || 'react-native')}/cli.js`, | ||
| ...args, | ||
| `--config=${c.runtime.runtimeExtraProps?.reactNativeMetroConfigName || 'metro.config.js'}` | ||
| ]; | ||
| return new Promise((resolve, reject) => { | ||
| child_process.execFile(command, commandArgs, { | ||
| env: { | ||
| @@ -70,4 +73,10 @@ | ||
| }, | ||
| } | ||
| ); | ||
| }, (error, stdout, stderr) => { | ||
| if (error) { | ||
| reject(error); | ||
| } else { | ||
| resolve(stdout); | ||
| } | ||
| }); | ||
| }); | ||
| }; |
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues
Npm releases
n/a