Merge branch 'fix/withRNVRNConfig' into fix/release-hotfixes

* fix/withRNVRNConfig: disable react-native-permissions for tvos fix/withRNVRNConfig
flexn-io · Jan 26, 2024 · c3ab334 · c3ab334
2 parents 697f9c6 + eb42003
commit c3ab334
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 3 deletions.
diff --git a/packages/app-harness/renative.json b/packages/app-harness/renative.json
@@ -57,7 +57,12 @@
             },
             "version": "2.3.0"
         },
-        "react-native-permissions": "3.10.1",
+        "react-native-permissions": {
+            "ios": {
+                "podName": "RNPermissions"
+            },
+            "version": "3.10.1"
+        },
         "react-native": {
             "android": {
                 "implementation": "// TEST"

diff --git a/packages/app-harness/src/app/index.tvos.tsx b/packages/app-harness/src/app/index.tvos.tsx
@@ -0,0 +1,13 @@
+import React from 'react';
+import { Text, View } from 'react-native';
+
+const App = () => {
+    return (
+        <View>
+            <Text>ReNative Harness</Text>
+            <Text>{`hermes: ${typeof HermesInternal === 'object' && HermesInternal !== null ? 'yes' : 'no'}`}</Text>
+        </View>
+    );
+};
+
+export default App;
diff --git a/packages/sdk-react-native/src/adapters.ts b/packages/sdk-react-native/src/adapters.ts
@@ -11,11 +11,11 @@ const getApplicationId = () => {
 const getSkipLinkingDeps = () => {
     const skipLinkingEnv = process.env.RNV_SKIP_LINKING;
     if (skipLinkingEnv) {
-        const plugins = skipLinkingEnv.split(',');
+        const plugins = skipLinkingEnv.split(',').map((item) => item.trim());
 
         return {
             dependencies: plugins.reduce((acc, plugin) => {
-                acc[`${plugin}`] = {
+                acc[plugin] = {
                     platforms: {
                         ios: null,
                     },