Merge pull request #1776 from flexn-io/chore/remove-e2e-app-deletion

remove app deletion in e2e workflows
flexn-io · Nov 6, 2024 · 67514f1 · 67514f1
2 parents fa38ec3 + deae79a
commit 67514f1
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 24 deletions.
diff --git a/.github/workflows/e2e-harness-android.yml b/.github/workflows/e2e-harness-android.yml
@@ -38,10 +38,6 @@ jobs:
             - name: E2E
               run: |
                   cd packages/app-harness && yarn e2e:android && kill $(lsof -t -i:8093)
-            - name: Delete app
-              run: |
-                  adb uninstall renative.harness.test
-              continue-on-error: true
             # Commented because e2e tests would fail due to minion issues
             # - name: Post message to Slack via Webhook
             #   if: ${{ github.event_name == 'push' && failure() }}

diff --git a/.github/workflows/e2e-harness-androidtv.yml b/.github/workflows/e2e-harness-androidtv.yml
@@ -37,10 +37,6 @@ jobs:
             - name: E2E
               run: |
                   cd packages/app-harness && yarn e2e:androidtv && kill $(lsof -t -i:8094)
-            - name: Delete app
-              run: |
-                  adb uninstall renative.harness.test
-              continue-on-error: true
             # Commented because e2e tests would fail due to minion issues
             # - name: Post message to Slack via Webhook
             #   if: ${{ github.event_name == 'push' && failure() }}

diff --git a/.github/workflows/e2e-template-android.yml b/.github/workflows/e2e-template-android.yml
@@ -37,10 +37,6 @@ jobs:
             - name: E2E
               run: |
                   cd packages/template-starter && yarn e2e:android && kill $(lsof -t -i:8083)
-            - name: Delete app
-              run: |
-                  adb uninstall renative.helloworld.test
-              continue-on-error: true
             # Commented because e2e tests would fail due to minion issues
             # - name: Post message to Slack via Webhook
             #   if: ${{ github.event_name == 'push' && failure() }}

diff --git a/.github/workflows/e2e-template-androidtv.yml b/.github/workflows/e2e-template-androidtv.yml
@@ -37,10 +37,6 @@ jobs:
             - name: E2E
               run: |
                   cd packages/template-starter && yarn e2e:androidtv && kill $(lsof -t -i:8084)
-            - name: Delete app
-              run: |
-                  adb uninstall renative.helloworld.test
-              continue-on-error: true
             # Commented because e2e tests would fail due to minion issues
             # - name: Post message to Slack via Webhook
             #   if: ${{ github.event_name == 'push' && failure() }}

diff --git a/packages/app-harness/package.json b/packages/app-harness/package.json
@@ -16,8 +16,8 @@
     },
     "scripts": {
         "bootstrap": "cd ../.. && yarn bootstrap",
-        "build:android-test": "npx rnv build -p android -s test -c harness --packageManager yarn --ci -r",
-        "build:androidtv-test": "npx rnv build -p androidtv -s test -c harness --packageManager yarn --ci -r",
+        "build:android-test": "npx rnv build -p android -s test -c harness --packageManager yarn --ci --yes -r",
+        "build:androidtv-test": "npx rnv build -p androidtv -s test -c harness --packageManager yarn --ci --yes -r",
         "build:ios-test": "npx rnv build -p ios -s test -c harness --packageManager yarn --ci -r",
         "build:macos-test": "npx rnv build -p macos -s test -c harness --packageManager yarn --ci -r",
         "build:tvos-test": "npx rnv build -p tvos -s test -c harness --packageManager yarn --ci -r",
@@ -30,8 +30,8 @@
         "report": "yarn report:generate && yarn report:open",
         "report:generate": "npx allure generate --clean reporting/allure-results -o reporting/allure-report",
         "report:open": "npx allure open reporting/allure-report",
-        "run:android-test": "npx rnv run -p android -s test -c harness --packageManager yarn --ci -r",
-        "run:androidtv-test": "npx rnv run -p androidtv -s test -c harness --packageManager yarn --ci -r",
+        "run:android-test": "npx rnv run -p android -s test -c harness --packageManager yarn --ci --yes -r",
+        "run:androidtv-test": "npx rnv run -p androidtv -s test -c harness --packageManager yarn --ci --yes -r",
         "run:ios-test": "npx rnv run -p ios -s test -c harness --packageManager yarn --ci -r",
         "run:tvos-test": "npx rnv run -p tvos -s test -c harness --packageManager yarn --ci -r",
         "run:web-test": "npx rnv run -p web -s test -c harness --packageManager yarn --ci",

diff --git a/packages/template-starter/package.json b/packages/template-starter/package.json
@@ -73,8 +73,8 @@
     },
     "scripts": {
         "bootstrap": "cd ../.. && yarn bootstrap",
-        "build:android-test": "npx rnv build -p android -s test -c template --packageManager yarn --ci -r",
-        "build:androidtv-test": "npx rnv build -p androidtv -s test -c template --packageManager yarn --ci -r",
+        "build:android-test": "npx rnv build -p android -s test -c template --packageManager yarn --ci --yes -r",
+        "build:androidtv-test": "npx rnv build -p androidtv -s test -c template --packageManager yarn --ci --yes -r",
         "build:ios-test": "npx rnv build -p ios -s test -c template --packageManager yarn --ci -r",
         "build:macos-test": "npx rnv build -p macos -s test -c template --packageManager yarn --ci -r",
         "build:tvos-test": "npx rnv build -p tvos -s test -c template --packageManager yarn --ci -r",
@@ -87,8 +87,8 @@
         "report": "yarn report:generate && yarn report:open",
         "report:generate": "npx allure generate --clean reporting/allure-results -o reporting/allure-report",
         "report:open": "npx allure open reporting/allure-report",
-        "run:android-test": "npx rnv run -p android -s test -c template --packageManager yarn --ci -r",
-        "run:androidtv-test": "npx rnv run -p androidtv -s test -c template --packageManager yarn --ci -r",
+        "run:android-test": "npx rnv run -p android -s test -c template --packageManager yarn --ci --yes -r",
+        "run:androidtv-test": "npx rnv run -p androidtv -s test -c template --packageManager yarn --ci --yes -r",
         "run:ios-test": "npx rnv run -p ios -s test -c template --packageManager yarn --ci -r",
         "run:tvos-test": "npx rnv run -p tvos -s test -c template --packageManager yarn --ci -r",
         "run:web-test": "npx rnv run -p web -s test -c template --packageManager yarn --ci",