Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update migration guide from a RN #33

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Marius456
Copy link
Contributor

Description

  • Update guide to be more coherent and easier to follow.

Related issues

@Marius456 Marius456 self-assigned this Nov 11, 2024
Copy link

vercel bot commented Nov 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
renative-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2024 7:17am
renative-docs-testing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2024 7:17am

Copy link
Contributor

@RicardasN RicardasN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we support react-native.config file as well, as that exists, perhaps there are some steps needed to move it?

- `src/` folder
```
"plugins": {
"react-native": "0.73.4"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think about plugins it should be stated, that renative does not use autolinking, which is used by react native, therefore not only the packages need to be moved to renative.json like you show, but should be moved as such:

"react-native": {
     "version": "0.73.4",
     "source": "rnv"
}

And if for some of their dependencies mapping does not exist, they will need to implement it


- `app`: This folder contains the main files for your application.
- `entry`: This folder allows you to configure the launch settings of your app. It is intended for advanced configuration and customization.
- `pages`: This folder enables you to create individual pages for your application.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be stated, that is reserved for Next.js, if they don't do web, they don't need it, they can also specify a different folder in appConfigs/renative.json, but this is not just for individual pages for all platforms


replace `src/` folder content with source content of your app (JS files)
:::warning Remember to Update Project Configuration Files
When transferring your project, it's essential not to overlook updating your configuration files. This includes:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe should mention that it would be with imports from renative withRnvBabel and such

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants