PEBC skeleton class implementation #60
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erEnvelope classes; remove obsolete PEBCPowerEnvelopeLimitType
…nergy constraint module
…nergy constraint module
"error": {
"message": "We could not parse the JSON body of your request. (HINT: This likely means you aren't using your HTTP library correctly. The OpenAI API expects a JSON payload, but what was sent was not valid JSON. If you have trouble figuring out how to fix this, please contact us through our help center at help.openai.com.)",
"type": "invalid_request_error",
"param": null,
"code": null
}
}
null
"model": "gpt-4",
"messages": [
{
"role": "system",
"content": "You are a helpful assistant that creates concise, meaningful git commit messages based on code changes."
},
{
"role": "user",
"content": "Generate a commit message for the following changes:\n src/s2python/pebc/pebc_instruction.py | 1 +
src/s2python/pebc/pebc_power_constraints.py | 1 +
2 files changed, 2 insertions(+)\nFiles changed:\nsrc/s2python/pebc/pebc_instruction.py,src/s2python/pebc/pebc_power_constraints.py,"
}
]
}
OpenAI API Response: {
"error": {
"message": "We could not parse the JSON body of your request. (HINT: This likely means you aren't using your HTTP library correctly. The OpenAI API expects a JSON payload, but what was sent was not valid JSON. If you have trouble figuring out how to fix this, please contact us through our help center at help.openai.com.)",
"type": "invalid_request_error",
"param": null,
"code": null
}
}
null
"model": "gpt-4",
"messages": [
{
"role": "system",
"content": "You are a helpful assistant that creates concise, meaningful git commit messages based on code changes."
},
{
"role": "user",
"content": "Generate a commit message for the following changes:\n src/s2python/pebc/pebc_instruction.py | 1 -
src/s2python/pebc/pebc_power_constraints.py | 1 -
2 files changed, 2 deletions(-)\nFiles changed:\nsrc/s2python/pebc/pebc_instruction.py,src/s2python/pebc/pebc_power_constraints.py"
}
]
}
OpenAI API Response: {
"error": {
"message": "We could not parse the JSON body of your request. (HINT: This likely means you aren't using your HTTP library correctly. The OpenAI API expects a JSON payload, but what was sent was not valid JSON. If you have trouble figuring out how to fix this, please contact us through our help center at help.openai.com.)",
"type": "invalid_request_error",
"param": null,
"code": null
}
}
null
"model": "gpt-4",
"messages": [
{
"role": "system",
"content": "You are a helpful assistant that creates concise, meaningful git commit messages based on code changes."
},
{
"role": "user",
"content": "Generate a commit message for the following changes:\n src/s2python/pebc/pebc_instruction.py | 1 + src/s2python/pebc/pebc_power_constraints.py | 1 + 2 files changed, 2 insertions(+) \nFiles changed:\nsrc/s2python/pebc/pebc_instruction.py,src/s2python/pebc/pebc_power_constraints.py,"
}
]
}
OpenAI API Response: {
"id": "chatcmpl-Al2WJ2cNcBy1e7SuAXcIMjLbcFdBs",
"object": "chat.completion",
"created": 1735774467,
"model": "gpt-4-0613",
"choices": [
{
"index": 0,
"message": {
"role": "assistant",
"content": "Added new code lines in pebc_instruction.py and pebc_power_constraints.py",
"refusal": null
},
"logprobs": null,
"finish_reason": "stop"
}
],
"usage": {
"prompt_tokens": 116,
"completion_tokens": 16,
"total_tokens": 132,
"prompt_tokens_details": {
"cached_tokens": 0,
"audio_tokens": 0
},
"completion_tokens_details": {
"reasoning_tokens": 0,
"audio_tokens": 0,
"accepted_prediction_tokens": 0,
"rejected_prediction_tokens": 0
}
},
"system_fingerprint": null
}
Added new code lines in pebc_instruction.py and pebc_power_constraints.py
"model": "gpt-4",
"messages": [
{
"role": "system",
"content": "You are a helpful assistant that creates concise, meaningful git commit messages based on code changes."
},
{
"role": "user",
"content": "Generate a commit message for the following changes:\n src/s2python/pebc/pebc_instruction.py | 1 - src/s2python/pebc/pebc_power_constraints.py | 1 - 2 files changed, 2 deletions(-) \nFiles changed:\nsrc/s2python/pebc/pebc_instruction.py,src/s2python/pebc/pebc_power_constraints.py,"
}
]
}
Removed unnecessary lines from pebc_instruction.py and pebc_power_constraints.py
"model": "gpt-4",
"messages": [
{
"role": "system",
"content": "You are a helpful assistant that creates concise, meaningful git commit messages based on code changes."
},
{
"role": "user",
"content": "Generate a commit message for the following changes:\n src/s2python/pebc/pebc_instruction.py | 1 + src/s2python/pebc/pebc_power_constraints.py | 1 + 2 files changed, 2 insertions(+) \nFiles changed:\nsrc/s2python/pebc/pebc_instruction.py,src/s2python/pebc/pebc_power_constraints.py,"
}
]
}
OpenAI API Response: {
"id": "chatcmpl-AlAbv6QhnCJYGj5n7bQAdF7PiD0iT",
"object": "chat.completion",
"created": 1735805567,
"model": "gpt-4-0613",
"choices": [
{
"index": 0,
"message": {
"role": "assistant",
"content": "Added new functionalities to pebc_instruction and pebc_power_constraints files",
"refusal": null
},
"logprobs": null,
"finish_reason": "stop"
}
],
"usage": {
"prompt_tokens": 116,
"completion_tokens": 14,
"total_tokens": 130,
"prompt_tokens_details": {
"cached_tokens": 0,
"audio_tokens": 0
},
"completion_tokens_details": {
"reasoning_tokens": 0,
"audio_tokens": 0,
"accepted_prediction_tokens": 0,
"rejected_prediction_tokens": 0
}
},
"system_fingerprint": null
}
Added new functionalities to pebc_instruction and pebc_power_constraints files
… modules in s2python.
…y files in s2python module
|
This will resolve #64 |
wcoenraads
requested changes
Jan 9, 2025
There was a problem hiding this comment.
Thanks for implementing this! Your changes look good to me; however, the control type still needs to be added to s2python/s2_control_type.py. If you add that, I think we can merge this.
P.S. I sent you an email with an extra question I had regarding the generated code.
I did not receive any emails. |
wcoenraads
requested changes
Jan 13, 2025
|
Another minor issue I discovered while working on a PEBC example: EDIT: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several new classes and updates existing ones in the
src/s2python/pebcdirectory. These changes primarily involve importing necessary modules, defining new classes, and configuring model validation. The most important changes include the addition of new classes for handling PEBC constraints and envelopes, as well as updating model configurations to enable assignment validation.