Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local execution e2e training #1472

Open
wants to merge 23 commits into
base: master
Choose a base branch
from

Format

dde9496
Select commit
Loading
Failed to load commit list.
Open

Local execution e2e training #1472

Format
dde9496
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Aug 27, 2024 in 0s

60.45% (-2.40%) compared to 5e1f349

View this Pull Request on Codecov

60.45% (-2.40%) compared to 5e1f349

Details

Codecov Report

Attention: Patch coverage is 2.72727% with 535 lines in your changes missing coverage. Please review.

Project coverage is 60.45%. Comparing base (5e1f349) to head (dde9496).

Files Patch % Lines
lib/local-execution/src/optimizer.cc 0.00% 111 Missing ⚠️
lib/local-execution/test/src/test_update_e2e.cc 1.19% 83 Missing ⚠️
lib/local-execution/test/src/test_loss_e2e.cc 1.25% 79 Missing ⚠️
lib/local-execution/src/local_training_backing.cc 0.00% 57 Missing ⚠️
lib/local-execution/src/local_slots_backing.cc 21.73% 36 Missing ⚠️
lib/local-execution/src/loss_functions.cc 0.00% 30 Missing ⚠️
.../local-execution/src/generic_task_impl_function.cc 0.00% 23 Missing ⚠️
lib/local-execution/src/task_invocation.cc 0.00% 23 Missing ⚠️
lib/kernels/src/array_shape.cc 8.69% 21 Missing ⚠️
lib/local-execution/src/model_training_instance.cc 0.00% 15 Missing ⚠️
... and 9 more
Additional details and impacted files
@@                Coverage Diff                @@
##           repo-refactor    #1472      +/-   ##
=================================================
- Coverage          62.84%   60.45%   -2.40%     
=================================================
  Files                497      507      +10     
  Lines              14150    14726     +576     
  Branches             415      431      +16     
=================================================
+ Hits                8893     8902       +9     
- Misses              5257     5824     +567     
Files Coverage Δ
lib/local-execution/src/ops/attention.cc 24.64% <ø> (ø)
...cal-execution/test/src/test_local_slots_backing.cc 98.36% <100.00%> (ø)
lib/local-execution/test/src/test_task_registry.cc 100.00% <ø> (ø)
lib/local-execution/src/task_signature_impl.cc 4.93% <0.00%> (ø)
lib/local-execution/src/local_cost_estimator.cc 0.00% <0.00%> (ø)
lib/local-execution/src/ops/element_unary.cc 0.00% <0.00%> (ø)
lib/op-attrs/src/loss_functions.cc 0.00% <0.00%> (ø)
lib/pcg/src/pcg/optimizer_attrs.cc 0.00% <0.00%> (ø)
...execution/include/local-execution/task_signature.h 0.00% <0.00%> (ø)
lib/pcg/src/pcg/computation_graph.cc 66.66% <0.00%> (-15.69%) ⬇️
... and 12 more

... and 3 files with indirect coverage changes