Skip to content

Commit

Permalink
Merge branch 'repo-refactor' into repo-refactor
Browse files Browse the repository at this point in the history
  • Loading branch information
Bob-Chen222 authored Apr 4, 2024
2 parents c21d66e + 1b0c32e commit 817065b
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 1 deletion.
2 changes: 1 addition & 1 deletion lib/substitutions/include/substitutions/operator_pattern.h
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ enum class OperatorAttributeKey {
NUM_INPUTS
};


/**
* @brief OperatorAttributeValue is a representation of the concrete value of an attribute of an Operator.
* The OperatorAttributeValue is evaluated from AttributeExpr. The datatype of the value corresponds to the
Expand Down Expand Up @@ -121,7 +122,6 @@ using OperatorAttributeConstraint =
using OperatorPattern =
AttributePattern<OperatorAttributeKey, OperatorAttributeValue>;


/**
* @brief Given a specific attribute of an Operator, evaluate the expression of the attribute
* using one of the three methods: direct value, list index access, or list size and return the
Expand Down
1 change: 1 addition & 0 deletions lib/substitutions/include/substitutions/output_graph.h
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ struct AttrConstant {
OperatorAttributeValue value;
};


/**
* @brief OperatorAttributeExpr is a access to the attribute of an operator and can be
* evaluated to a concrete value. OperatorAttributeExpr is used at substitution phase.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ namespace FlexFlow {
*/
enum class TensorAttributeKey { DIM_SIZES, DIM_DEGREES };


/**
* @brief DIM_SIZES and DIM_DEGREES are represented by
* a vector of ints that is listed as corresponding dimension
Expand All @@ -34,6 +35,7 @@ using TensorAttributeConstraint =
using ParallelTensorPattern =
AttributePattern<TensorAttributeKey, TensorAttributeValue>;


/**
* @brief evaluate_attribute_expr evaluates the attribute expression for a given ParallelTensor
* the ParallelTensor parameter is named tensor_shape because the numerical value will only be used
Expand Down

0 comments on commit 817065b

Please sign in to comment.