Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customer Outreach Examples #12

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

thomascfd
Copy link
Contributor

@thomascfd thomascfd commented Aug 15, 2023

This PR contains scripts for the customer outreach examples updated based on recent Flow360Scripts guidelines.

Options for case submission are both from Mesh ID (added to examples in admin portal, but not visible in new python client. To use this, log-in to examples account directly) and upload from S3 (currently many meshes are not uploaded yet so "PLACEHOLDER" put in place of URL. Meshes can also be taken from the google drive folder https://drive.google.com/drive/folders/1cmuOoGXwFsOaUbI1oKaKhWpDJ-8DaxAf and ran with the submit_cases_from_downloads.py scripts.

XV15 adaptive CFL contains two JSON files as "volume zones" still doesn't work in new python client. We will remove legacy json once it does.

Some pylint issues still exist due to capitalization or recent .format change in print_divergence_locations.py.

@cjdoolittle
Copy link

cjdoolittle commented Sep 7, 2023

@thomascfd this looks really nice, thanks for the great work. I worked through the Wall_Model example in detail: reviewed code, formatted, and committed some changes. I think these edits are likely to be applicable to the other examples as well. Please take a look at the commit differences and see what makes sense to forward to the other examples.

Some additional recommendations:
• Include (brief) overview of example intention starting the individual README files
• Add a "*" or similar to step #1 of README directing user to following footnote about localFiles use
○ I attempted to add footnote formatting, but whatever Markdown we're using seems to not support syntax
• Suggest argument type for --localFiles True/False (boolean) instead of 1/0 (integer)
• Files.py relocate case_json = 'local://Flow360.json' outside of class url definition → always local in repo
• CJ to upload grids to S3? Ready for this?
• Thomas alternative method to change boundary "type", without need to reenter "name"?

@thomascfd thomascfd requested a review from cjdoolittle December 5, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants