Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BET translator #634

Open
wants to merge 21 commits into
base: develop
Choose a base branch
from
Open

BET translator #634

wants to merge 21 commits into from

Conversation

wiktor-flex
Copy link
Collaborator

@wiktor-flex wiktor-flex commented Dec 20, 2024 •
edited
Loading

Done

  • unittest comparing both individual values and dicts against reference files
  • C81
  • DFDC
  • XFoil
  • XROTOR
  • MultiConstructorBaseModel for BETDisk class
  • original input file contents as private attributes
  • entitylist working properly
  • alias for generate_xrotor_bet_json so that dfdc doesn't use the same name

Some files are left in order to decide which unittests to delete

There are 2 kinds of unittests for BET translator currently:

  • compare individual values between a translated output and original reference json
  • compare translated output json with a new reference json

BET will mostly likely need to be separated form volume_models.py as it takes a considerable amount of lines of code

@wiktor-flex wiktor-flex self-assigned this Dec 20, 2024
@wiktor-flex wiktor-flex marked this pull request as draft December 20, 2024 16:20
@wiktor-flex wiktor-flex force-pushed the wiktor/bet_translator branch from c83b586 to 7c6d085 Compare December 20, 2024 16:21
@wiktor-flex wiktor-flex marked this pull request as ready for review January 3, 2025 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciej-flexcompute maciej-flexcompute Awaiting requested review from maciej-flexcompute

@benflexcompute benflexcompute Awaiting requested review from benflexcompute

@angranl-flex angranl-flex Awaiting requested review from angranl-flex

At least 1 approving review is required to merge this pull request.

Assignees

@wiktor-flex wiktor-flex

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wiktor-flex