-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additionalFormats to fallback and make formats public #415
Conversation
Co-Authored-By: cotw-fabier <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #415 +/- ##
=======================================
Coverage 87.94% 87.94%
=======================================
Files 62 62
Lines 10363 10364 +1
=======================================
+ Hits 9114 9115 +1
Misses 1249 1249 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I guess the natice autoformats are made public to allow users to cherrypick
It would be nice to add a comment in the PR (to avoid guessing the reason :))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add test?
I found it unnecessary, but if you think it's needed I can add the test too. @amantoux |
If not too long to write, I think it is worth |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Based on #372.
Made current auto formats public for users to be able to cherrypick.