Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use record instead of list in html_utils.toRGBA #413

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

Amir-P
Copy link
Member

@Amir-P Amir-P commented Aug 23, 2024

No description provided.

@Amir-P Amir-P requested a review from amantoux August 23, 2024 10:39
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.94%. Comparing base (e725636) to head (1dbca0c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #413      +/-   ##
==========================================
- Coverage   87.94%   87.94%   -0.01%     
==========================================
  Files          62       62              
  Lines       10364    10363       -1     
==========================================
- Hits         9115     9114       -1     
  Misses       1249     1249              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@amantoux amantoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Amir-P Amir-P merged commit e60be6c into master Aug 23, 2024
4 checks passed
@Amir-P Amir-P deleted the ref/use_records_in_to_rgba_html_util branch August 23, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants