Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for automatic mode in color selection buttons #187

Merged
merged 3 commits into from
Dec 8, 2023

Conversation

amantoux
Copy link
Member

@amantoux amantoux commented Dec 7, 2023

Closes #172

@amantoux amantoux requested a review from Amir-P December 7, 2023 18:09
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (6ba157f) 84.55% compared to head (7b58999) 84.78%.
Report is 1 commits behind head on master.

Files Patch % Lines
...kages/fleather/lib/src/widgets/editor_toolbar.dart 90.90% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #187      +/-   ##
==========================================
+ Coverage   84.55%   84.78%   +0.23%     
==========================================
  Files          60       60              
  Lines        9617     9796     +179     
==========================================
+ Hits         8132     8306     +174     
- Misses       1485     1490       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Amir-P
Amir-P previously requested changes Dec 7, 2023
Copy link
Member

@Amir-P Amir-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "No Color" or "Transparent" or "Remove background color" is a better term than "Automatic" since that's what really happening. WDYT?

@amantoux
Copy link
Member Author

amantoux commented Dec 7, 2023

I think "No Color" or "Transparent" or "Remove background color" is a better term than "Automatic" since that's what really happening. WDYT?

I used MS Word wording for the text color. I believe the rational behind this is that the color automatically shifts from light mode color to dark mode color. Other possibilities not not have dynamic colors

image

For the background color, we should use 'No color', I agree

@amantoux
Copy link
Member Author

amantoux commented Dec 7, 2023

Changed accordingly ✅

@amantoux amantoux requested a review from Amir-P December 7, 2023 22:25
@amantoux amantoux dismissed Amir-P’s stale review December 7, 2023 22:43

Changed as agreed

Copy link
Member

@Amir-P Amir-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@amantoux amantoux merged commit cd886f0 into master Dec 8, 2023
4 checks passed
@amantoux amantoux deleted the feat/automatic_color branch December 8, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle no color selection for text & background color
2 participants