-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for automatic mode in color selection buttons #187
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #187 +/- ##
==========================================
+ Coverage 84.55% 84.78% +0.23%
==========================================
Files 60 60
Lines 9617 9796 +179
==========================================
+ Hits 8132 8306 +174
- Misses 1485 1490 +5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think "No Color" or "Transparent" or "Remove background color" is a better term than "Automatic" since that's what really happening. WDYT?
Changed accordingly ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Closes #172