Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt to Flutter 3.16 API changes #176

Merged
merged 7 commits into from
Dec 1, 2023
Merged

Adapt to Flutter 3.16 API changes #176

merged 7 commits into from
Dec 1, 2023

Conversation

amantoux
Copy link
Member

@amantoux amantoux commented Nov 23, 2023 •
edited
Loading

Closes #173

@amantoux amantoux marked this pull request as draft November 23, 2023 08:27
@amantoux amantoux changed the title Adapt to Flutter API changes Adapt to Flutter 3.16 API changes Nov 23, 2023
@amantoux
Copy link
Member Author

Tests fail to flutter/flutter#138709

@codecov Codecov
Copy link

codecov bot commented Nov 30, 2023 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (74447c4) 84.02% compared to head (4d652ec) 85.48%.
Report is 2 commits behind head on master.

Files Patch % Lines
...es/fleather/lib/src/rendering/paragraph_proxy.dart 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #176      +/-   ##
==========================================
+ Coverage   84.02%   85.48%   +1.45%     
==========================================
  Files          60       60              
  Lines        9361    10217     +856     
==========================================
+ Hits         7866     8734     +868     
+ Misses       1495     1483      -12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Amir-P Amir-P marked this pull request as ready for review November 30, 2023 17:45
@Amir-P Amir-P self-requested a review November 30, 2023 17:45
@Amir-P
Copy link
Member

Amir-P commented Nov 30, 2023 •
edited
Loading

Could you please take a look at it Alan? I can't request a review from you since you're the creator. @amantoux

@Amir-P Amir-P removed their request for review November 30, 2023 17:47
@amantoux
Copy link
Member Author

LGTM, will add removal of deprecated textScaleFactor

@amantoux amantoux requested a review from Amir-P November 30, 2023 19:31
Amir-P
Amir-P approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@Amir-P Amir-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@amantoux amantoux merged commit 5bac76d into master Dec 1, 2023
3 of 4 checks passed
@amantoux amantoux deleted the flutter_3_16 branch December 1, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amir-P Amir-P Amir-P approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flutter 3.16
2 participants
@amantoux @Amir-P