Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HTML encoder for tangled inline tags #174

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

amantoux
Copy link
Member

@amantoux amantoux commented Nov 21, 2023

Addresses partially #171

@amantoux amantoux force-pushed the fix_html_codec_tangled_inline_tags branch from 654fbf7 to 7b56de1 Compare November 21, 2023 15:59
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (74447c4) 84.02% compared to head (7b56de1) 84.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #174      +/-   ##
==========================================
+ Coverage   84.02%   84.07%   +0.04%     
==========================================
  Files          60       60              
  Lines        9361     9389      +28     
==========================================
+ Hits         7866     7894      +28     
  Misses       1495     1495              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amantoux amantoux requested a review from Amir-P November 21, 2023 16:36
Copy link
Member

@Amir-P Amir-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Any Idea why check fails?

@amantoux amantoux merged commit 56ee00f into master Nov 22, 2023
3 of 4 checks passed
@amantoux
Copy link
Member Author

amantoux commented Nov 22, 2023

LGTM. Any Idea why check fails?

Sometime send coverage report to Codecov fails for an unknown reason
Restarting failed job solves the problem...

@amantoux amantoux deleted the fix_html_codec_tangled_inline_tags branch November 22, 2023 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants