Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exception thrown when inserting new line with toggled inline styles #161

Merged
merged 2 commits into from
Sep 23, 2023
Merged

Fix exception thrown when inserting new line with toggled inline styles #161

merged 2 commits into from
Sep 23, 2023

Conversation

Amir-P
Copy link
Member

@Amir-P Amir-P commented Sep 9, 2023

Fixes #159

@Amir-P Amir-P requested a review from amantoux September 9, 2023 13:24
@codecov
Copy link

codecov bot commented Sep 9, 2023 •
edited
Loading

Codecov Report

Merging #161 (19bd909) into master (187ac7a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #161      +/-   ##
==========================================
+ Coverage   84.01%   84.02%   +0.01%     
==========================================
  Files          60       60              
  Lines        9350     9361      +11     
==========================================
+ Hits         7855     7866      +11     
  Misses       1495     1495
Files Changed Coverage Δ
packages/fleather/lib/src/widgets/controller.dart 97.63% <100.00%> (+0.15%) ⬆️
packages/fleather/lib/util.dart 92.00% <100.00%> (+1.09%) ⬆️

amantoux
amantoux requested changes Sep 17, 2023
View reviewed changes
Copy link
Member

@amantoux amantoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, some nitpicks

packages/fleather/lib/src/widgets/controller.dart Outdated Show resolved Hide resolved
packages/fleather/lib/src/widgets/controller.dart Show resolved Hide resolved
packages/fleather/lib/util.dart Outdated Show resolved Hide resolved
packages/fleather/lib/util.dart Outdated Show resolved Hide resolved
@Amir-P Amir-P requested a review from amantoux September 20, 2023 06:11
amantoux
amantoux approved these changes Sep 23, 2023
View reviewed changes
Copy link
Member

@amantoux amantoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good for here

@amantoux amantoux merged commit 74447c4 into fleather-editor:master Sep 23, 2023
3 checks passed
@Amir-P Amir-P deleted the fix/new_line_with_toggled_inline_styles_exception branch September 23, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amantoux amantoux amantoux approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inserting new line when inline styles like bold is toggled causes exception
2 participants
@Amir-P @amantoux