Support strike through in markdown codec

fleather-editor · Nov 23, 2023 · 3f9ab69 · 3f9ab69
1 parent 7ddce8e
commit 3f9ab69
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/packages/parchment/lib/src/codecs/markdown.dart b/packages/parchment/lib/src/codecs/markdown.dart
@@ -449,7 +449,7 @@ class _ParchmentMarkdownEncoder extends Converter<ParchmentDocument, String> {
     } else if (attribute == ParchmentAttribute.inlineCode) {
       _writeInlineCodeTag(buffer);
     } else if (attribute == ParchmentAttribute.strikethrough) {
-      _writeInlineCodeTag(buffer);
+      _writeStrikeThoughTag(buffer);
     } else if (attribute?.key == ParchmentAttribute.link.key) {
       _writeLinkTag(buffer, attribute as ParchmentAttribute<String>,
           close: close);
@@ -475,6 +475,10 @@ class _ParchmentMarkdownEncoder extends Converter<ParchmentDocument, String> {
     buffer.write('`');
   }
 
+  void _writeStrikeThoughTag(StringBuffer buffer) {
+    buffer.write('~~');
+  }
+
   void _writeLinkTag(StringBuffer buffer, ParchmentAttribute<String> link,
       {bool close = false}) {
     if (close) {

diff --git a/packages/parchment/test/codecs/markdown_test.dart b/packages/parchment/test/codecs/markdown_test.dart
@@ -9,7 +9,7 @@ import 'package:quill_delta/quill_delta.dart';
 import 'package:test/test.dart';
 
 void main() {
-  group('$ParchmentMarkdownCodec.decode', () {
+  group('ParchmentMarkdownCodec.decode', () {
     test('should convert empty markdown to valid empty document', () {
       final markdown = '';
       final newParchment = ParchmentDocument();
@@ -405,7 +405,7 @@ void main() {
     });
   });
 
-  group('$ParchmentMarkdownCodec.encode', () {
+  group('ParchmentMarkdownCodec.encode', () {
     test('split adjacent paragraphs', () {
       final delta = Delta()..insert('First line\nSecond line\n');
       final result =
@@ -429,7 +429,8 @@ void main() {
 
       runFor(ParchmentAttribute.bold, 'This **house** is a **circus**\n\n');
       runFor(ParchmentAttribute.italic, 'This _house_ is a _circus_\n\n');
-      runFor(ParchmentAttribute.strikethrough, 'This ~~house~~ is a ~~circus~~\n\n');
+      runFor(ParchmentAttribute.strikethrough,
+          'This ~~house~~ is a ~~circus~~\n\n');
     });
 
     test('intersecting inline styles', () {