Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Clarify PrepareInstall response #1088

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs: Clarify PrepareInstall response #1088

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion data/org.freedesktop.portal.DynamicLauncher.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,13 @@
<varlistentry>
<term>name s</term>
<listitem><para>
The name chosen by the user for the launcher.
The name chosen by the user for the launcher or the predefined one.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The name chosen by the user for the launcher or the predefined one.
The name chosen by the user for the launcher, or the predefined one.

Also: who chooses the "predefined" name? The portal implementation? The host?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The caller of PrepareInstall can pass name/icon and they can edited by the user if the call to PrepareInstall allows them to

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So not sure if predefined is the correct wording

</para></listitem>
</varlistentry>
<varlistentry>
<term>icon v</term>
<listitem><para>
The icon chosen by the user for the launcher or the predefined one.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The icon chosen by the user for the launcher or the predefined one.
The icon chosen by the user for the launcher, or the predefined one.

Same as above: who chooses the predefined icon?

</para></listitem>
</varlistentry>
<varlistentry>
Expand Down
Loading