Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vercel deployment workflow #116

Merged
merged 3 commits into from
Jul 1, 2024
Merged

Add Vercel deployment workflow #116

merged 3 commits into from
Jul 1, 2024

Conversation

magland
Copy link
Collaborator

@magland magland commented Jul 1, 2024

Auto deploy main branch to stan-playground.vercel.app

If we decide to go with stan-playground.flatironinstitute.org it will effectively deploy to that domain as well.

@WardBrian
Copy link
Collaborator

Looks good. If you wanted to move it into the other .yaml file you could have the deploy gated on the fact that the tests pass, which might be nice, but I think this is fine as is

Copy link
Collaborator

@jsoules jsoules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable enough. I haven't tried executing it as I don't know that I actually have keys to do so, but I'm satisfied if you have done so.

Comment on lines +8 to +9
# manual trigger
workflow_dispatch:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, does this mean this task is triggered manually or is that a way to trigger it manually?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can optionally be triggered manually in addition to automatically.

@magland magland merged commit 5961ba6 into main Jul 1, 2024
3 checks passed
@WardBrian WardBrian deleted the vercel-deploy-2 branch July 8, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants