Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use release 2021.3.0 of TBB #110

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Use release 2021.3.0 of TBB #110

merged 2 commits into from
Jun 28, 2024

Conversation

WardBrian
Copy link
Collaborator

The patch we need is now officially in a released version, so we don't have to use a specific commit any longer.

@jsoules
Copy link
Collaborator

jsoules commented Jun 28, 2024

Rebuilding the docker image works fine and the result successfully compiles the demo code. I think this is good to go, but I'll note that I do get a warning about mixing the case between a FROM and an AS in the docker files somewhere.

I don't see that in the files touched by this PR though, so I think you're good to go.

Copy link
Collaborator

@jsoules jsoules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tch, missed it right under my own eyes. Good call.

@WardBrian WardBrian merged commit 1f70164 into main Jun 28, 2024
2 checks passed
@WardBrian WardBrian deleted the use-released-tbb branch June 28, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants