Simplifying lowering and abstract evaluation rules #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfm
commented
May 2, 2024
| else: | ||
| return source.update( | ||
| shape=source.shape[:2] + (points[0].shape[-1],), dtype=source_dtype | ||
| ) |
There was a problem hiding this comment.
This is an unrelated change that I noticed. We're no longer supposed to manually construct a ShapedArray here because it should return the same type as the input (tracer vs concrete value).
lgarrison
approved these changes
May 2, 2024
|
@lgarrison — Good point! It looks like the oldest version of JAX that this supports is 0.4.20 from Nov 2023. This would make us somewhat bleeding edge, but I'm not too concerned about that. What do you think? |
|
I think that sounds fine, we already have a release that works with older JAX on PyPI. LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With relatively recent versions of JAX we can remove some of the boilerplate in the MLIR lowering rules.