Updating the installation documentation #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgarrison
requested changes
Apr 22, 2024
| ```bash | ||
| mamba create -n gpu-jax-finufft -c conda-forge python numpy scipy fftw 'gxx<12' | ||
| mamba activate gpu-jax-finufft | ||
| export CMAKE_PREFIX_PATH=$CONDA_PREFIX:$CMAKE_PREFIX_PATH |
There was a problem hiding this comment.
Did we decide to remove this from the default instructions?
There was a problem hiding this comment.
I don't know whether or not we need it for this one. The package that seems to set it automatically is cxx-compiler, which isn't installed here, but I haven't tested this one, so I just kept it more or less the same as what you had before.
There was a problem hiding this comment.
Oh, good call. The reason we're using gxx<12 is because CUDA 11 only supports GCC <= 11. CUDA 12 does support GCC 12.1, but cxx-compilers might install a newer version... so let's leave this as-is, I agree!
dfm
commented
Apr 22, 2024
lgarrison
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #81, this PR will update the installation instructions to be a little more complete and structured. Still a WIP.