Fix 1D GPU warning, and a few build improvements #126
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was confused why a user's build wasn't working, until I realized that the test code was 1D, which isn't implemented on the GPU. We were getting a low-level error message instead of our friendly error, because the check to emit the friendly error was
if platform == "gpu"
instead ofif platform == "cuda"
. This PR fixes that.While trying to diagnose this, I noticed a few other places to improve the build:
FINUFFT_CUDA_ARCHITECTURES
was usingnative
no matter the value ofCMAKE_CUDA_ARCHITECTURES
, so now we propagate that value;FINUFFT_ARCH_FLAGS
is-march=native
by default, so now we document that;CMAKE_CUDA_ARCHITECTURES
usually defaults to an old value that works but triggers PTX JIT at runtime, so now we set it tonative
(and document that).I also revamped the instructions for passing CMake args to the build.