Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 1D GPU warning, and a few build improvements #126

Merged
merged 6 commits into from
Dec 22, 2024
Merged

Conversation

lgarrison
Copy link
Member

@lgarrison lgarrison commented Dec 8, 2024

I was confused why a user's build wasn't working, until I realized that the test code was 1D, which isn't implemented on the GPU. We were getting a low-level error message instead of our friendly error, because the check to emit the friendly error was if platform == "gpu" instead of if platform == "cuda". This PR fixes that.

While trying to diagnose this, I noticed a few other places to improve the build:

  • FINUFFT_CUDA_ARCHITECTURES was using native no matter the value of CMAKE_CUDA_ARCHITECTURES, so now we propagate that value;
  • FINUFFT_ARCH_FLAGS is -march=native by default, so now we document that;
  • CMAKE_CUDA_ARCHITECTURES usually defaults to an old value that works but triggers PTX JIT at runtime, so now we set it to native (and document that).

I also revamped the instructions for passing CMake args to the build.

@lgarrison lgarrison requested a review from dfm December 8, 2024 18:21
README.md Show resolved Hide resolved
@lgarrison lgarrison merged commit 2cf881e into main Dec 22, 2024
5 checks passed
@lgarrison lgarrison deleted the 1d-warn-and-build branch December 22, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants