Skip to content

Commit

Permalink
readme: [-3pi, 3pi] restriction was lifted in finufft 2.3
Browse files Browse the repository at this point in the history
  • Loading branch information
lgarrison committed Dec 8, 2024
1 parent 9b76bf0 commit f4b0aa2
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -247,13 +247,6 @@ c = np.random.standard_normal(size=M) + 1j * np.random.standard_normal(size=M)
f = nufft1(N, c, x, eps=1e-6, iflag=1)
```

> [!WARNING]
> As described in [the FINUFFT
> documentation](https://finufft.readthedocs.io/en/latest/math.html), the
> non-uniform points must lie within the range `[-3pi, 3pi]`, but this is _not
> checked_, because JAX currently doesn't have a good interface for runtime
> value checking. Unexpected crashes may occur if this condition is not met.
Noting that the `eps` and `iflag` are optional, and that (for good reason, I
promise!) the order of the positional arguments is reversed from the `finufft`
Python package.
Expand Down

0 comments on commit f4b0aa2

Please sign in to comment.