Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom basename when saving mcorr memmaps #950

Closed
wants to merge 2 commits into from
Closed

Allow custom basename when saving mcorr memmaps #950

wants to merge 2 commits into from

Conversation

kushalkolar
Copy link
Collaborator

Description

Currently, if the same input file is put through motion correction with different parameter variants the resulting motion corrected memmap will always have the same filename. I could not find a way to set the filename of mcorrr memmaps that are saved when setting save_movie=True in MotionCorrect.motion_correct().

I added a kwarg called base_name_prefix to MotionCorrect.motion_correct() which allows a user to append a prefix to the basename that is used when saving memmaps. By default it is set to None, but if a user supplies a str it will set that as a prefix to the base_name when saving the memmap.

Let me know if there's a better way to do this!

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would break back-compatibility)
  • Changes in documentation or new examples for demos and/or use cases.

Branching

targets dev

Has your PR been tested?

Tested that currently functionality isn't broken by running test_demos.sh, no failures. Also tested the new functionality and it does work, prefixes are set to saved memmaps.

@kushalkolar
Copy link
Collaborator Author

closing because this has been replaced by #978 which has already been merged.

@kushalkolar kushalkolar closed this Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant